[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 02/11] ide: ahci: reset ncq object to unused on er
From: |
John Snow |
Subject: |
[Qemu-devel] [PULL v2 02/11] ide: ahci: reset ncq object to unused on error |
Date: |
Mon, 11 Jan 2016 14:33:51 -0500 |
From: Prasad J Pandit <address@hidden>
When processing NCQ commands, AHCI device emulation prepares a
NCQ transfer object; To which an aio control block(aiocb) object
is assigned in 'execute_ncq_command'. In case, when the NCQ
command is invalid, the 'aiocb' object is not assigned, and NCQ
transfer object is left as 'used'. This leads to a use after
free kind of error in 'bdrv_aio_cancel_async' via 'ahci_reset_port'.
Reset NCQ transfer object to 'unused' to avoid it.
[Maintainer edit: s/ACHI/AHCI/ in the commit message. --js]
Reported-by: Qinghao Tang <address@hidden>
Signed-off-by: Prasad J Pandit <address@hidden>
Reviewed-by: John Snow <address@hidden>
Message-id: address@hidden
Signed-off-by: John Snow <address@hidden>
---
hw/ide/ahci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index dd1912e..17f1cbd 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -910,6 +910,7 @@ static void ncq_err(NCQTransferState *ncq_tfs)
ide_state->error = ABRT_ERR;
ide_state->status = READY_STAT | ERR_STAT;
ncq_tfs->drive->port_regs.scr_err |= (1 << ncq_tfs->tag);
+ ncq_tfs->used = 0;
}
static void ncq_finish(NCQTransferState *ncq_tfs)
--
2.4.3
- [Qemu-devel] [PULL v2 00/11] Ide patches, John Snow, 2016/01/11
- [Qemu-devel] [PULL v2 01/11] macio: fix overflow in lba to offset conversion for ATAPI devices, John Snow, 2016/01/11
- [Qemu-devel] [PULL v2 06/11] libqos/ahci: Switch to mutable properties, John Snow, 2016/01/11
- [Qemu-devel] [PULL v2 05/11] libqos/ahci: ATAPI identify, John Snow, 2016/01/11
- [Qemu-devel] [PULL v2 07/11] libqos: allow zero-size allocations, John Snow, 2016/01/11
- [Qemu-devel] [PULL v2 10/11] qtest/ahci: ATAPI data tests, John Snow, 2016/01/11
- [Qemu-devel] [PULL v2 03/11] ahci-test: fix memory leak, John Snow, 2016/01/11
- [Qemu-devel] [PULL v2 02/11] ide: ahci: reset ncq object to unused on error,
John Snow <=
- [Qemu-devel] [PULL v2 04/11] libqos/ahci: ATAPI support, John Snow, 2016/01/11
- [Qemu-devel] [PULL v2 08/11] libqos/ahci: allow nondata commands for ahci_io variants, John Snow, 2016/01/11
- [Qemu-devel] [PULL v2 11/11] libqos/ahci: organize header, John Snow, 2016/01/11
- [Qemu-devel] [PULL v2 09/11] libqos/ahci: add ahci_exec, John Snow, 2016/01/11
- Re: [Qemu-devel] [PULL v2 00/11] Ide patches, Peter Maydell, 2016/01/12