Re: [Qemu-devel] [PATCH] qemu-char: do not leak QemuMutex when freeing a character device

[Daniel P. Berrange]

On Fri, Jan 15, 2016 at 04:17:01PM +0100, Paolo Bonzini wrote:
> The leak is only apparent on Win32.  On POSIX platforms destroying a
> mutex is not necessary.
> 
> Reported-by: Eric Blake <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  qemu-char.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Daniel P. Berrange <address@hidden>

> diff --git a/qemu-char.c b/qemu-char.c
> index 02b0318..c7b8699 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -3967,6 +3967,7 @@ static void qemu_chr_free_common(CharDriverState *chr)
>      if (chr->logfd != -1) {
>          close(chr->logfd);
>      }
> +    qemu_mutex_destroy(&chr->chr_write_lock);
>      g_free(chr);
>  }

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|