Re: [Qemu-devel] [PATCH v1 05/15] crypto: add block encryption framework

[Eric Blake]

On 01/14/2016 05:16 AM, Daniel P. Berrange wrote:

>>> +# @qcowaes: QCow/QCow2 built-in AES-CBC encryption. Do not use
>>> +#
>>
>> Well, the only reason to use it would be to read data off an old
>> insecurely-encrypted qcow2 file; so maybe it should read "Do not use on
>> new files"
> 
> Yep
> 
>>> +# Since: 2.6
>>> +##
>>> +{ 'enum': 'QCryptoBlockFormat',
>>> +#  'prefix': 'QCRYPTO_BLOCK_FORMAT',
>>> +  'data': ['qcowaes']}
>>
>> Would 'qcow-aes' be any easier to read?
> 
> Or just shorten to 'qcow' perhaps ?

Or maybe 'old-qcow' to emphasize that it is old?  At this point, we're
painting the bikeshed, so I'll live with whatever you like.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature