[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 0/7] Netfilter: Add each netdev a default fi
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH RFC 0/7] Netfilter: Add each netdev a default filter |
Date: |
Fri, 22 Jan 2016 10:07:57 +0000 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, Jan 22, 2016 at 04:36:44PM +0800, zhanghailiang wrote:
> This series is a prerequisite for COLO, here we add each netdev
> a default buffer filter, it is disabled by default, and has
> no side effect for delivering packets in net layer.
Why can't whatever is launching QEMU just setup filters explicitly
if they want to use COLO ? I'm not seeing an obvious compelling
reason to add this by default and then add extra code to deal
with special casing its behaviour.
>
> Besides, patch 1 fixes the ouput information of 'info network' command
> for filter.
>
> zhanghailiang (7):
> net/filter: Fix the output information for command 'info network'
> net/filter: Add a 'status' property for filter object
> net/filter: Skip the disabled filter when delivering packets
> net/filter: Introduce a helper to add a filter to the netdev
> filter-buffer: Accept zero interval
> net/filter: Add a default filter to each netdev
> net/filter: prevent the default filter to be deleted
>
> include/net/filter.h | 25 +++++++-
> net/dump.c | 2 -
> net/filter-buffer.c | 10 ----
> net/filter.c | 163
> +++++++++++++++++++++++++++++++++++++++++++++------
> net/net.c | 27 ++++++++-
> 5 files changed, 194 insertions(+), 33 deletions(-)
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- Re: [Qemu-devel] [PATCH RFC 3/7] net/filter: Skip the disabled filter when delivering packets, (continued)
[Qemu-devel] [PATCH RFC 5/7] filter-buffer: Accept zero interval, zhanghailiang, 2016/01/22
[Qemu-devel] [PATCH RFC 6/7] net/filter: Add a default filter to each netdev, zhanghailiang, 2016/01/22
Re: [Qemu-devel] [PATCH RFC 0/7] Netfilter: Add each netdev a default filter, Hailiang Zhang, 2016/01/22
Re: [Qemu-devel] [PATCH RFC 0/7] Netfilter: Add each netdev a default filter,
Daniel P. Berrange <=
Re: [Qemu-devel] [PATCH RFC 0/7] Netfilter: Add each netdev a default filter, Jason Wang, 2016/01/24