Re: [Qemu-devel] [FreeBSD] Build Failure, qemu-char.c

[Sean Bruno]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512



On 01/22/16 08:47, Peter Maydell wrote:

> This one is just straightforwardly BSD-only code that hasn't been
> compile-tested.
> 
>> qemu-char.c:4265:36: warning: incompatible pointer types passing 
>> 'ChardevCommon *' (aka 'struct ChardevCommon *') to parameter of
>> type 'ChardevBackend *' (aka 'struct ChardevBackend *') 
>> [-Wincompatible-pointer-types] return qemu_chr_open_pp_fd(fd,
>> common, errp); ^~~~~~ qemu-char.c:1838:61: note: passing argument
>> to parameter 'backend' here ChardevBackend *backend,
> 
> This one looks like it ought to build on Linux so you're probably 
> right about it being a clang-only thing. (We do build with clang on
> OSX but I think there the CHARDEV_PARPORT code is not compiled
> in.)
> 
> thanks -- PMM
> 

Yeah, this is smack in the middle of #ifdef (random BSD) here.  It
looks like a simple copy/paste error where "common" should have been
"backend".  Fixes the build failure, but still emits a cast warning.
I think this is the intent of the changes however.

index e133f4f..73eb10f 100644
- --- a/qemu-char.c
+++ b/qemu-char.c
@@ -1840,7 +1840,7 @@ static CharDriverState *qemu_chr_open_pp_fd(int fd,
 {
     CharDriverState *chr;

- -    chr = qemu_chr_alloc(common, errp);
+    chr = qemu_chr_alloc(backend, errp);
     if (!chr) {
         return NULL;
     }
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQF8BAEBCgBmBQJWol5RXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRCQUFENDYzMkU3MTIxREU4RDIwOTk3REQx
MjAxRUZDQTFFNzI3RTY0AAoJEBIB78oecn5k8+IH/RRQP1AD8c+eNo4IcTUMIm8o
voNYHPUgwYAfEyXPewJwyXHlZG5cMJ2rrxUue9WaXJ/TsyRtxhsAi3PLoJcXzTWE
UvOZgZT3M6Xo0EcMy/PTf66Kc57/V7zrKxS5BDlBZp/yRCzrVkenmCmY/NjoqQq/
ZXPx7UpI5ec6debSalfwT67jboLJlvwhVibSR9/kAf0IbWQBFien9WC1RJmXvKJ2
Mk831symwxR8WaTeccP9tWytFC+CmHHqCssaSL7wkqmrwVKGDNrEDe7r6FftyY2a
3NPm8X3ahEkwE7m0fbNq03O3liw//reM8LRoyIKWQgA3M6pSYpXVGmwZXMpYA4I=
=O8aP
-----END PGP SIGNATURE-----