[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v17 7/9] add MachineClass->default_props for set
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v17 7/9] add MachineClass->default_props for setting default device properties |
Date: |
Sat, 23 Jan 2016 12:59:56 -0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, Jan 19, 2016 at 02:06:27PM +0100, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> include/hw/boards.h | 1 +
> vl.c | 4 ++++
> 2 files changed, 5 insertions(+)
>
> diff --git a/include/hw/boards.h b/include/hw/boards.h
> index 0f30959..d495611 100644
> --- a/include/hw/boards.h
> +++ b/include/hw/boards.h
> @@ -90,6 +90,7 @@ struct MachineClass {
> const char *default_machine_opts;
> const char *default_boot_order;
> const char *default_display;
> + GlobalProperty *default_props;
> GlobalProperty *compat_props;
Could you explain (in a comment?) the purpose of each field? They
seem to do exactly the same thing, so why couldn't they become a
single linked list, where the compat classes just append new
items to the existing default_props list?
(If we build default_props by appending instead of overwriting
the parent class list, we will be able to finally eliminate
PC_COMPAT_* macro nesting)
--
Eduardo
- [Qemu-devel] [PATCH v17 0/9] Virtual Machine Generation ID, Igor Mammedov, 2016/01/19
- [Qemu-devel] [PATCH v17 1/9] acpi: extend ACPI interface to provide access to ACPI registers and SCI irq, Igor Mammedov, 2016/01/19
- [Qemu-devel] [PATCH v17 3/9] pc: add a Virtual Machine Generation ID device, Igor Mammedov, 2016/01/19
- [Qemu-devel] [PATCH v17 4/9] tests: add a unit test for the vmgenid device., Igor Mammedov, 2016/01/19
- [Qemu-devel] [PATCH v17 2/9] docs: vm generation id device's description, Igor Mammedov, 2016/01/19
- [Qemu-devel] [PATCH v17 5/9] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands, Igor Mammedov, 2016/01/19
- [Qemu-devel] [PATCH v17 7/9] add MachineClass->default_props for setting default device properties, Igor Mammedov, 2016/01/19
- Re: [Qemu-devel] [PATCH v17 7/9] add MachineClass->default_props for setting default device properties,
Eduardo Habkost <=
- [Qemu-devel] [PATCH v17 9/9] pc/q53: by default put vmgenid device as an function of ISA bridge, Igor Mammedov, 2016/01/19
- [Qemu-devel] [PATCH v17 6/9] qmp/hmp: add set-vm-generation-id commands, Igor Mammedov, 2016/01/19
- [Qemu-devel] [PATCH v17 8/9] pc: put PIIX3 in slot 1 explicitly and cleanup functions assignment, Igor Mammedov, 2016/01/19
- Re: [Qemu-devel] [PATCH v17 0/9] Virtual Machine Generation ID, Igor Mammedov, 2016/01/19