[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 10/11] Add Error **errp for xen_pt_config_init()
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PULL 10/11] Add Error **errp for xen_pt_config_init() |
Date: |
Mon, 25 Jan 2016 10:53:13 +0000 |
User-agent: |
Alpine 2.02 (DEB 1266 2009-07-14) |
On Sat, 23 Jan 2016, Cao jin wrote:
> On 01/22/2016 07:21 PM, Paolo Bonzini wrote:
> >
> >
> > On 21/01/2016 18:01, Stefano Stabellini wrote:
> > > - XEN_PT_LOG(&s->dev, "Failed to initialize %d/%ld
> > > reg 0x%x in grp_type=0x%x (%d/%ld), rc=%d\n",
> > > - j,
> > > ARRAY_SIZE(xen_pt_emu_reg_grps[i].emu_regs),
> > > - regs->offset,
> > > xen_pt_emu_reg_grps[i].grp_type,
> > > - i, ARRAY_SIZE(xen_pt_emu_reg_grps),
> > > rc);
> > > + xen_pt_config_reg_init(s, reg_grp_entry, regs, &err);
> > > + if (err) {
> > > + error_append_hint(&err, "Failed to initialize
> > > %d/%zu"
> > > + " reg 0x%x in grp_type = 0x%x (%d/%zu)",
> > > + j,
> > > ARRAY_SIZE(xen_pt_emu_reg_grps[i].emu_regs),
> >
> > Coverity noticed a preexisting problem here. emu_regs is a pointer,
> > thus ARRAY_SIZE doesn't return what you expect.
> >
> Hi stefano,
>
> Seems ARRAY_SIZE(xen_pt_emu_reg_grps[i].emu_regs) is not important err message
> to regular users, and I guess it still can help developer to debug even
> without it. So, do you think it is ok to remove it? Or any better idea?
Yes, it is OK to remove it.
- [Qemu-devel] [PULL 0/11] xen-20160121, Stefano Stabellini, 2016/01/21
- [Qemu-devel] [PULL 03/11] xen-hvm: Clean up xen_hvm_init() error handling, Stefano Stabellini, 2016/01/21
- [Qemu-devel] [PULL 05/11] xen-pvdevice: convert to realize(), Stefano Stabellini, 2016/01/21
- [Qemu-devel] [PULL 01/11] MAINTAINERS: update Xen files, Stefano Stabellini, 2016/01/21
- [Qemu-devel] [PULL 06/11] Change xen_host_pci_sysfs_path() to return void, Stefano Stabellini, 2016/01/21
- [Qemu-devel] [PULL 08/11] Add Error **errp for xen_host_pci_device_get(), Stefano Stabellini, 2016/01/21
- [Qemu-devel] [PULL 09/11] Add Error **errp for xen_pt_setup_vga(), Stefano Stabellini, 2016/01/21
- [Qemu-devel] [PULL 02/11] xenfb.c: avoid expensive loops when prod <= out_cons, Stefano Stabellini, 2016/01/21
- [Qemu-devel] [PULL 11/11] Xen PCI passthru: convert to realize(), Stefano Stabellini, 2016/01/21
- Re: [Qemu-devel] [PULL 0/11] xen-20160121, Peter Maydell, 2016/01/21