[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/5] q35: Remove old machines and unused comp
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/5] q35: Remove old machines and unused compat code |
Date: |
Mon, 25 Jan 2016 12:27:47 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 |
On 01/23/16 17:02, Eduardo Habkost wrote:
> This is another attempt to remove old q35 machine code. Now I am
> also removing unused compat code to demonstrate the benefit of
> throwing away the old code that nobody uses.
>
> Eduardo Habkost (5):
> q35: Remove old machine versions
> machine: Remove no_tco field
> ich9: Remove enable_tco arguments from init functions
> q35: Remove unused q35-acpi-dsdt.aml file
> q35: No need to check gigabyte_align
>
> Makefile | 2 +-
> hw/acpi/ich9.c | 8 +--
> hw/i386/pc_q35.c | 176
> +---------------------------------------------
> hw/isa/lpc_ich9.c | 4 +-
> include/hw/acpi/ich9.h | 1 -
> include/hw/boards.h | 1 -
> include/hw/i386/ich9.h | 2 +-
> pc-bios/q35-acpi-dsdt.aml | Bin 7344 -> 0 bytes
> 8 files changed, 9 insertions(+), 185 deletions(-)
> delete mode 100644 pc-bios/q35-acpi-dsdt.aml
>
I read / skimmed the earlier discussion:
http://thread.gmane.org/gmane.comp.emulators.qemu/356340
http://thread.gmane.org/gmane.comp.emulators.qemu/382574
For patches 1, 2, 3, 5:
Reviewed-by: Laszlo Ersek <address@hidden>
For patch 4:
How about removing the following two files in addition:
- hw/i386/q35-acpi-dsdt.dsl
- hw/i386/q35-acpi-dsdt.hex.generated
and updating the references in "hw/i386/Makefile.objs"?
Thanks
Laszlo
- [Qemu-devel] [PATCH v2 0/5] q35: Remove old machines and unused compat code, Eduardo Habkost, 2016/01/23
- [Qemu-devel] [PATCH v2 1/5] q35: Remove old machine versions, Eduardo Habkost, 2016/01/23
- [Qemu-devel] [PATCH v2 2/5] machine: Remove no_tco field, Eduardo Habkost, 2016/01/23
- [Qemu-devel] [PATCH v2 3/5] ich9: Remove enable_tco arguments from init functions, Eduardo Habkost, 2016/01/23
- [Qemu-devel] [PATCH v2 4/5] q35: Remove unused q35-acpi-dsdt.aml file, Eduardo Habkost, 2016/01/23
- [Qemu-devel] [PATCH v2 5/5] q35: No need to check gigabyte_align, Eduardo Habkost, 2016/01/23
- Re: [Qemu-devel] [PATCH v2 0/5] q35: Remove old machines and unused compat code,
Laszlo Ersek <=
- Re: [Qemu-devel] [PATCH v2 0/5] q35: Remove old machines and unused compat code, Igor Mammedov, 2016/01/26
- [Qemu-devel] [PATCH 6/5] pc: Remove unused pc_acpi_init() function, Eduardo Habkost, 2016/01/26
- [Qemu-devel] [PATCH 7/5] acpi: Remove unused acpi_table_add_builtin() function, Eduardo Habkost, 2016/01/26