Re: [Qemu-devel] [PATCH v2] configure: sanity check the glib library that pkg-config finds

[Daniel P. Berrange]

On Mon, Jan 25, 2016 at 02:58:22PM +0000, Peter Maydell wrote:
> On 25 January 2016 at 14:47, Daniel P. Berrange <address@hidden> wrote:
> > AFAIK, no one raised a blocking issue with it.
> 
> I've just found one :-)  which is that it fails on my OSX build system:
> 
> config-temp/qemu-conf.c:5:4: error: unused typedef '_GStaticAssert_5'
> [-Werror,-Wunused-local-typedef]
>    G_STATIC_ASSERT(sizeof(size_t) == GLIB_SIZEOF_SIZE_T);
>    ^
> /sw/include/glib-2.0/glib/gmacros.h:143:96: note: expanded from macro
> 'G_STATIC_ASSERT'
> #define G_STATIC_ASSERT(expr) typedef struct { char
> Compile_Time_Assertion[(expr) ? 1 : -1]; } G_PASTE (_GStaticAssert_,
> __LINE__)
> 
>                         ^
> /sw/include/glib-2.0/glib/gmacros.h:142:47: note: expanded from macro 
> 'G_PASTE'
> #define G_PASTE(identifier1,identifier2)      G_PASTE_ARGS
> (identifier1, identifier2)
>                                               ^
> /sw/include/glib-2.0/glib/gmacros.h:141:47: note: expanded from macro
> 'G_PASTE_ARGS'
> #define G_PASTE_ARGS(identifier1,identifier2) identifier1 ## identifier2
>                                               ^
> <scratch space>:170:1: note: expanded from here
> _GStaticAssert_5
> ^
> 1 error generated.
> 
> The annotation of gmacros.h to mark the typedef as deliberately unused
> didn't happen until after the version of glib I have. G_STATIC_ASSERT
> is probably best avoided in QEMU code (we have QEMU_BUILD_BUG_ON
> anyway).

I'm travelling for a few days, but will investigate and re-post an update
once i return.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|