[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] net/traffic-mirrorer:Add traffic-mirroer
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] net/traffic-mirrorer:Add traffic-mirroer |
|
Date: |
Wed, 27 Jan 2016 09:10:49 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 01/26/2016 05:44 PM, Hailiang Zhang wrote:
> On 2016/1/26 16:59, Zhang Chen wrote:
>> From: ZhangChen <address@hidden>
>>
>> Traffic-mirrorer is a plugin of netfilter.
>> It make qemu has ability to copy and mirror guest's
>> net packet. we output packet to chardev.
>>
>> +static void traffic_mirrorer_setup(NetFilterState *nf, Error **errp)
>> +{
>> + MirrorerState *s = FILTER_TRAFFIC_MIRRORER(nf);
>> +
>> + if (!s->outdev) {
>> + error_setg(errp, "filter traffic mirrorer needs 'outdev'
>> property set!"
>> + "property set!");
>
> Duplicate 'property set!'.
For that matter, error_setg() messages should never end in '!'.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature