[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 01/10] exec: Remove cpu from cpus list during cpu
From: |
Matthew Rosato |
Subject: |
[Qemu-devel] [PATCH v3 01/10] exec: Remove cpu from cpus list during cpu_exec_exit() |
Date: |
Wed, 27 Jan 2016 11:53:32 -0500 |
From: Bharata B Rao <address@hidden>
CPUState *cpu gets added to the cpus list during cpu_exec_init(). It
should be removed from cpu_exec_exit().
cpu_exec_init() is called from generic CPU::instance_finalize and some
archs like PowerPC call it from CPU unrealizefn. So ensure that we
dequeue the cpu only once.
Now -1 value for cpu->cpu_index indicates that we have already dequeued
the cpu for CONFIG_USER_ONLY case also.
Signed-off-by: Bharata B Rao <address@hidden>
Reviewed-by: David Gibson <address@hidden>
---
exec.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/exec.c b/exec.c
index 7115403..c8da9d4 100644
--- a/exec.c
+++ b/exec.c
@@ -596,6 +596,7 @@ void cpu_exec_exit(CPUState *cpu)
return;
}
+ QTAILQ_REMOVE(&cpus, cpu, node);
bitmap_clear(cpu_index_map, cpu->cpu_index, 1);
cpu->cpu_index = -1;
}
@@ -614,6 +615,15 @@ static int cpu_get_free_index(Error **errp)
void cpu_exec_exit(CPUState *cpu)
{
+ cpu_list_lock();
+ if (cpu->cpu_index == -1) {
+ cpu_list_unlock();
+ return;
+ }
+
+ QTAILQ_REMOVE(&cpus, cpu, node);
+ cpu->cpu_index = -1;
+ cpu_list_unlock();
}
#endif
--
1.9.1
- [Qemu-devel] [PATCH v3 00/10] Allow hotplug of s390 CPUs, Matthew Rosato, 2016/01/27
- [Qemu-devel] [PATCH v3 01/10] exec: Remove cpu from cpus list during cpu_exec_exit(),
Matthew Rosato <=
- [Qemu-devel] [PATCH v3 10/10] s390x/cpu: Allow hot plug/unplug of CPUs, Matthew Rosato, 2016/01/27
- [Qemu-devel] [PATCH v3 02/10] exec: Do vmstate unregistration from cpu_exec_exit(), Matthew Rosato, 2016/01/27
- [Qemu-devel] [PATCH v3 05/10] s390x/cpu: Cleanup init in preparation for hotplug, Matthew Rosato, 2016/01/27
- [Qemu-devel] [PATCH v3 08/10] s390x/cpu: Add functions to (un)register CPU state, Matthew Rosato, 2016/01/27
- [Qemu-devel] [PATCH v3 07/10] s390x/cpu: Move some CPU initialization into realize, Matthew Rosato, 2016/01/27
- [Qemu-devel] [PATCH v3 09/10] s390/virtio-ccw: Add hotplug handler and prepare for unplug, Matthew Rosato, 2016/01/27
- [Qemu-devel] [PATCH v3 03/10] cpu: Reclaim vCPU objects, Matthew Rosato, 2016/01/27
- [Qemu-devel] [PATCH v3 04/10] cpu: Add a sync version of cpu_remove(), Matthew Rosato, 2016/01/27
- [Qemu-devel] [PATCH v3 06/10] s390x/cpu: Set initial CPU state in common routine, Matthew Rosato, 2016/01/27