[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC][PATCH v5 0/5] utils: Improve and document error repor
From: |
Lluís Vilanova |
Subject: |
[Qemu-devel] [RFC][PATCH v5 0/5] utils: Improve and document error reporting |
Date: |
Thu, 28 Jan 2016 22:53:32 +0100 |
User-agent: |
StGit/0.17.1-dirty |
Adds leaner error-reporting functions for simple cases, and documents the
purpose of the different facilities available in QEMU.
Although not all printf+exit/abort are replaced with the proper functions, a few
are ported as an example.
Changes in v5
=============
* Fix typo in documentation [Eric Blake].
Changes in v4
=============
* Introduce 'error_report_fatal()' and 'error_report_abort()' functions
[suggested by Thomas Huth].
* Repalce all existing uses of 'error_setg(error_fatal)' and
'error_setg(error_abort)' with 'error_report_fatal()' and
'error_report_abort()'.
* Replace all uses of 'exit()' with 'error_report_fatal()' in 'target-ppc'.
* Replace all uses of 'abort()' with 'error_report_abort()' in 'target-ppc'.
Changes in v3
=============
* Drop special object 'error_warn' in favour of raw 'error_report()'
[suggested by Markus Armbruster].
Changes in v2
=============
* Split in two patches.
* Explicitly add a warning error object.
Signed-off-by: Lluís Vilanova <address@hidden>
---
Lluís Vilanova (5):
util: Introduce error reporting functions with fatal/abort
util: Use new error_report_fatal/abort instead of
error_setg(&error_fatal/abort)
util: [ppc] Use new error_report_fatal() instead of exit()
util: [ppc] Use new error_report_abort() instead of abort()
doc: Introduce coding style for errors
HACKING | 33 ++++++++++++++++++
hw/block/fdc.c | 6 ++-
hw/ppc/spapr.c | 8 ++--
hw/ppc/spapr_drc.c | 2 +
include/qemu/error-report.h | 19 ++++++++++
target-ppc/kvm.c | 9 ++---
target-ppc/kvm_ppc.h | 15 +++++---
target-ppc/mmu-hash32.c | 5 ++-
target-ppc/mmu_helper.c | 3 +-
target-ppc/translate.c | 7 ++--
target-ppc/translate_init.c | 80 +++++++++++++++++++++----------------------
util/error.c | 9 ++---
util/qemu-error.c | 33 ++++++++++++++++++
13 files changed, 155 insertions(+), 74 deletions(-)
To: address@hidden
Cc: Stefan Hajnoczi <address@hidden>
Cc: Dr. David Alan Gilbert <address@hidden>
Cc: Thomas Huth <address@hidden>
Cc: Markus Armbruster <address@hidden>
Cc: Eric Blake <address@hidden>