Re: [Qemu-devel] ping: [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

[Eric Blake]

On 02/02/2016 09:21 PM, Programmingkid wrote:

>>> #if defined(__APPLE__) && defined(__MACH__)
>>>        /* if a physical device experienced an error while being opened */
>>>        if (strncmp((*bsd_path ? bsd_path : filename), "/dev/", 5) == 0) {
>>>            print_unmounting_directions(*bsd_path ? bsd_path : filename);
>>>            return -1;
>>>        }
>>
>> A bit repetitive. You don't use filename after the fact, so shorter
>> would be:
>>
>> #if defined(__APPLE__)...
>>    if (*bsd_path) {
>>        filename = filename;

Oops, I shouldn't be writing emails late at night.  Let's try this again.

if (*bsd_path) {
    filename = bsd_path;
}
if (strncmp(filename, ...

Hopefully that makes more sense.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature