qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4/5] virtio-balloon: rewrite get_current_ram_siz


From: Cornelia Huck
Subject: Re: [Qemu-devel] [PATCH 4/5] virtio-balloon: rewrite get_current_ram_size()
Date: Thu, 4 Feb 2016 13:59:37 +0100

On Thu, 4 Feb 2016 15:36:05 +0300
Vladimir Sementsov-Ogievskiy <address@hidden> wrote:

> On 04.02.2016 15:23, Cornelia Huck wrote:
> > On Thu,  4 Feb 2016 14:37:22 +0300
> > Vladimir Sementsov-Ogievskiy <address@hidden> wrote:

> >> +    pc_dimm_build_list(qdev_get_machine(), &list);
> > This will break the build for !CONFIG_MEM_HOTPLUG, as you didn't
> > provide a stubbed-out version of this function.
> 
> Ok, thanks, will add.
> 
> Also: it is already broken because of pc_dimm_memory_plug and 
> pc_dimm_memory_unplug

These are only used by targets that set CONFIG_MEM_HOTPLUG afaics.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]