Re: [Qemu-devel] [PATCH 2/5] pc-dimm: rename pc_dimm_built_list()

[Igor Mammedov]

On Fri,  5 Feb 2016 11:18:58 +0300
Vladimir Sementsov-Ogievskiy <address@hidden> wrote:

> s/pc_dimm_built_list/pc_dimm_build_list_sorted
> 
> - need for add pc_dimm_build_list (not sorted) in the next patch
> - fix typo (built -> build)
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>

> ---
>  hw/mem/pc-dimm.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
> index 4f30950..4a681bc 100644
> --- a/hw/mem/pc-dimm.c
> +++ b/hw/mem/pc-dimm.c
> @@ -251,7 +251,7 @@ static gint pc_dimm_addr_sort(gconstpointer a, 
> gconstpointer b)
>      return 0;
>  }
>  
> -static int pc_dimm_built_list(Object *obj, void *opaque)
> +static int pc_dimm_build_list_sorted(Object *obj, void *opaque)
>  {
>      GSList **list = opaque;
>  
> @@ -262,7 +262,7 @@ static int pc_dimm_built_list(Object *obj, void *opaque)
>          }
>      }
>  
> -    object_child_foreach(obj, pc_dimm_built_list, opaque);
> +    object_child_foreach(obj, pc_dimm_build_list_sorted, opaque);
>      return 0;
>  }
>  
> @@ -296,7 +296,7 @@ uint64_t pc_dimm_get_free_addr(uint64_t 
> address_space_start,
>      }
>  
>      assert(address_space_end > address_space_start);
> -    object_child_foreach(qdev_get_machine(), pc_dimm_built_list, &list);
> +    object_child_foreach(qdev_get_machine(), pc_dimm_build_list_sorted, 
> &list);
>  
>      if (hint) {
>          new_addr = *hint;