qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] MAINTAINERS: add all-match entry for qemu-devel


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] MAINTAINERS: add all-match entry for qemu-devel@
Date: Mon, 8 Feb 2016 20:56:02 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0


On 08/02/2016 20:15, Peter Maydell wrote:
> That difference from the kernel script's behaviour is deliberate, because
> the attempt to list recent contributors tends to list a whole lot of
> irrelevant people. So if there's a documented maintainer we prefer to
> just list them, and not all the random other people looking at the git
> logs drags up. Commit c6561586f0f8586 is where we changed the behaviour
> of get_maintainer.pl and the commit message has some rationale.

It should be enough not to check @list_to in the line that commit
c6561586f0f8586 adds:

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 7dacf32..f2ee9d8 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -636,7 +636,7 @@ sub get_maintainers {
 
     if ($email) {
        if (! $interactive) {
-           $email_git_fallback = 0 if @email_to > 0 || @list_to > 0 || 
$email_git || $email_git_blame;
+           $email_git_fallback = 0 if @email_to > 0 || $email_git || 
$email_git_blame;
            if ($email_git_fallback) {
                print STDERR "get_maintainer.pl: No maintainers found, printing 
recent contributors.\n";
                print STDERR "get_maintainer.pl: Do not blindly cc: them on 
patches!  Use common sense.\n";

I think this makes sense.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]