[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] trace: use addresses instead of offsets in
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] trace: use addresses instead of offsets in memory tracepoints |
Date: |
Tue, 9 Feb 2016 15:53:39 +0000 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, Feb 08, 2016 at 04:03:05PM -0800, Hollis Blanchard wrote:
> -memory_region_ops_read(void *mr, uint64_t offset, uint64_t value, unsigned
> size) "mr %p offset %#"PRIx64" value %#"PRIx64" size %u"
> -memory_region_ops_write(void *mr, uint64_t offset, uint64_t value, unsigned
> size) "mr %p offset %#"PRIx64" value %#"PRIx64" size %u"
> +memory_region_ops_read(void *mr, uint64_t addr, uint64_t value, unsigned
> size) "mr %p offset %#"PRIx64" value %#"PRIx64" size %u"
> +memory_region_ops_write(void *mr, uint64_t addr, uint64_t value, unsigned
> size) "mr %p offset %#"PRIx64" value %#"PRIx64" size %u"
Please update the format string too ("offset" -> "addr").
Stefan
signature.asc
Description: PGP signature