[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 5/5] balloon: Use only 'pc-dimm' type dimm for ballo
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[Qemu-devel] [PATCH 5/5] balloon: Use only 'pc-dimm' type dimm for ballooning |
Date: |
Wed, 10 Feb 2016 11:49:26 +0300 |
For now there are only two dimm's: pc-dimm and nvdimm. This patch is
actually needed to disable ballooning on nvdimm. But, to avoid future
bugs, instead of disallowing nvdimm, we allow only pc-dimm. So, if
someone adds new dimm which should be balloon-able, then this ability
should be explicitly specified here.
Why ballooning for nvdimm should be disabled for now:
NVDIMM for now is planned to use as a backing store for DAX filesystem
in the guest and thus this memory is excluded from guest memory
management and LRUs.
In this case libvirt running QEMU along with configured balloon almost
immediately inflates balloon and effectively kill the guest as
qemu counts nvdimm as part of the ram.
Counting dimm devices as part of the ram for ballooning was started from
commit 463756d03:
virtio-balloon: Fix balloon not working correctly when hotplug memory
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Signed-off-by: Denis V. Lunev <address@hidden>
---
hw/virtio/virtio-balloon.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index 14aab77..d312380 100644
--- a/hw/virtio/virtio-balloon.c
+++ b/hw/virtio/virtio-balloon.c
@@ -302,7 +302,10 @@ static ram_addr_t get_current_ram_size(void)
pc_dimm_build_list(qdev_get_machine(), &list);
for (item = list; item; item = g_slist_next(item)) {
Object *obj = OBJECT(item->data);
- size += object_property_get_int(obj, PC_DIMM_SIZE_PROP, &error_abort);
+ if (!strcmp(object_get_typename(obj), TYPE_PC_DIMM)) {
+ size += object_property_get_int(obj, PC_DIMM_SIZE_PROP,
+ &error_abort);
+ }
}
g_slist_free(list);
--
1.8.3.1
- [Qemu-devel] [PATCH v7 0/5] don't use NVDIMM for balooning, Vladimir Sementsov-Ogievskiy, 2016/02/10
- [Qemu-devel] [PATCH 5/5] balloon: Use only 'pc-dimm' type dimm for ballooning,
Vladimir Sementsov-Ogievskiy <=
- [Qemu-devel] [PATCH 4/5] virtio-balloon: rewrite get_current_ram_size(), Vladimir Sementsov-Ogievskiy, 2016/02/10
- [Qemu-devel] [PATCH 1/5] move get_current_ram_size to virtio-balloon.c, Vladimir Sementsov-Ogievskiy, 2016/02/10
- [Qemu-devel] [PATCH 3/5] pc-dimm: add pc_dimm_build_list(), Vladimir Sementsov-Ogievskiy, 2016/02/10
- [Qemu-devel] [PATCH 2/5] pc-dimm: rename pc_dimm_built_list(), Vladimir Sementsov-Ogievskiy, 2016/02/10
- Re: [Qemu-devel] [PATCH v7 0/5] don't use NVDIMM for balooning, Denis V. Lunev, 2016/02/16
- Re: [Qemu-devel] [PATCH v7 0/5] don't use NVDIMM for balooning, Denis V. Lunev, 2016/02/22
- Re: [Qemu-devel] [PATCH v7 0/5] don't use NVDIMM for balooning, Xiao Guangrong, 2016/02/23