qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/3] qdev-monitor: sort alias table by typename


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 1/3] qdev-monitor: sort alias table by typename
Date: Thu, 11 Feb 2016 09:53:29 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Sascha Silbe <address@hidden> writes:

> Sort the alias table by typename so it's easier to see which aliases
> exist.
>
> Signed-off-by: Sascha Silbe <address@hidden>
> ---
>  qdev-monitor.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/qdev-monitor.c b/qdev-monitor.c
> index 81e3ff3..0145deb 100644
> --- a/qdev-monitor.c
> +++ b/qdev-monitor.c
> @@ -40,18 +40,18 @@ typedef struct QDevAlias
>  } QDevAlias;
>  
>  static const QDevAlias qdev_alias_table[] = {

Suggest to add

       /* Please keep this table sorted */

> -    { "virtio-blk-pci", "virtio-blk", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
> -    { "virtio-net-pci", "virtio-net", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
> -    { "virtio-serial-pci", "virtio-serial", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X 
> },
> +    { "e1000", "e1000-82540em" },
> +    { "ich9-ahci", "ahci" },
> +    { "kvm-pci-assign", "pci-assign" },
> +    { "lsi53c895a", "lsi" },
>      { "virtio-balloon-pci", "virtio-balloon",
>              QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
>      { "virtio-blk-ccw", "virtio-blk", QEMU_ARCH_S390X },
> +    { "virtio-blk-pci", "virtio-blk", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
>      { "virtio-net-ccw", "virtio-net", QEMU_ARCH_S390X },
> +    { "virtio-net-pci", "virtio-net", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
>      { "virtio-serial-ccw", "virtio-serial", QEMU_ARCH_S390X },
> -    { "lsi53c895a", "lsi" },
> -    { "ich9-ahci", "ahci" },
> -    { "kvm-pci-assign", "pci-assign" },
> -    { "e1000", "e1000-82540em" },
> +    { "virtio-serial-pci", "virtio-serial", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X 
> },
>      { }
>  };

Reviewed-by: Markus Armbruster <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]