[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC versi
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version |
Date: |
Mon, 15 Feb 2016 15:49:57 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, 02/15 15:34, Peter Xu wrote:
> On Mon, Feb 15, 2016 at 12:54:57AM -0600, Wei Huang wrote:
> > On 2/13/16 23:41, Peter Xu wrote:
> > > One question: how should I make this command "ARM only"? I see that
> > > in qmp-commands.hx, I can use something like "#if defined
> > > TARGET_ARM" to block out ARM specified commands, however how should
> > > I do the similiar thing in qapi-schema.json?
> >
> > This situation is similar to "rtc-reset-reinjection", right? I think You
> > can disable this feature on other arch's by setting
> > QERR_FEATURE_DISABLED in file like monitor.c.
>
> Yes. Will include this when post the real patches.
Yes, I think returning an error for non-ARM targets suffices.
Fam
- [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version, Peter Xu, 2016/02/14
- [Qemu-devel] [RFC PATCH 1/2] arm: gic: add GICType, Peter Xu, 2016/02/14
- [Qemu-devel] [RFC PATCH 2/2] arm: gic: add "query-gic-capability" interface, Peter Xu, 2016/02/14
- Re: [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version, Wei Huang, 2016/02/15
- Re: [Qemu-devel] [libvirt] [RFC PATCH 0/2] ARM: add QMP command to query GIC version, Martin Kletzander, 2016/02/15
- Re: [Qemu-devel] [libvirt] [RFC PATCH 0/2] ARM: add QMP command to query GIC version, Peter Xu, 2016/02/15
- Re: [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version, Markus Armbruster, 2016/02/15