[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/4] Error location reporting fixes
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/4] Error location reporting fixes |
Date: |
Mon, 15 Feb 2016 11:33:03 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Eduardo Habkost <address@hidden> writes:
> This fixes the following bugs in error reporting:
>
> $ qemu-system-x86_64 -icount rr=x -vnc :0
> qemu-system-x86_64: -vnc :0: Invalid icount rr option: x
>
> $ qemu-system-x86_64 -m size= -vnc :0
> qemu-system-x86_64: -vnc :0: missing 'size' option value
>
> The last command-line option (-vnc) is being shown in the error
> message, instead of the -m or -icount options.
>
> This also includes a patch submitted previously by Marcel, to
> ensure there are no ordering conflicts when applying the patches.
> Marcel's patch fixes the following bug:
>
> $ qemu-system-x86_64 -M q35-1.5 -redir tcp:8022::22
> qemu-system-x86_64: -redir tcp:8022::22: unsupported machine type
> Use -machine help to list supported machines
I have two minor suggestions. Regardless:
Reviewed-by: Markus Armbruster <address@hidden>
I can take the series through my tree. Of course, Paolo merging it
through his would also be fine.
- Re: [Qemu-devel] [PATCH v2 1/4] vl.c: Fix regression in machine error message, (continued)
[Qemu-devel] [PATCH v2 3/4] replay: Set error location properly when parsing options, Eduardo Habkost, 2016/02/12
[Qemu-devel] [PATCH v2 2/4] vl: Reset location after handling command-line arguments, Eduardo Habkost, 2016/02/12
[Qemu-devel] [PATCH v2 4/4] vl: Set error location when parsing memory options, Eduardo Habkost, 2016/02/12
Re: [Qemu-devel] [PATCH v2 0/4] Error location reporting fixes,
Markus Armbruster <=
[Qemu-devel] [PATCH 5/4] vl: Clean up machine selection in main()., Markus Armbruster, 2016/02/16
Re: [Qemu-devel] [PATCH v2 0/4] Error location reporting fixes, Markus Armbruster, 2016/02/16