Re: [Qemu-devel] [PATCH v2 09/14] hw/timer: QOM'ify milkymist_sysctl

[Peter Maydell]

On 27 January 2016 at 02:54, xiaoqiang zhao <address@hidden> wrote:
> * split milkymist_sysctl_init into milkymist_sysctl_info.instance_init and 
> milkymist_sysctl_realize

I think the "info" in this function name is wrong ?

> * use DeviceClass::realize instead of SysBusDeviceClass::init

Please make sure you line wrap your commit messages (at somewhere
around 70-72 columns is usual).

Otherwise:
Reviewed-by: Peter Maydell <address@hidden>

Again, you should cc the maintainer for this device.

thanks
-- PMM