qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 14/14] hw/timer: QOM'ify tusb6010 and remove


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v2 14/14] hw/timer: QOM'ify tusb6010 and remove all tabs
Date: Mon, 15 Feb 2016 18:20:11 +0000

On 27 January 2016 at 02:56, xiaoqiang zhao <address@hidden> wrote:
> * assign tusb6010_init to tusb6010_info.instance_init and drop the 
> SysBusDeviceClass::init
> * use spaces instead of tabs

Please don't do whitespace/indentation changes and real
code changes in the same patch. Indent changes should always
go in their own patch if you really need to make them (though
in this case I would not bother personally).

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]