[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] block/backup: make backup cluster size conf
|
From: |
John Snow |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/3] block/backup: make backup cluster size configurable |
|
Date: |
Tue, 16 Feb 2016 08:38:40 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 02/14/2016 01:46 AM, Fam Zheng wrote:
> On Fri, 02/12 18:06, John Snow wrote:
>> typedef struct CowRequest {
>> @@ -46,6 +43,8 @@ typedef struct BackupBlockJob {
>> CoRwlock flush_rwlock;
>> uint64_t sectors_read;
>> HBitmap *bitmap;
>> + int64_t cluster_size;
>> + int64_t sectors_per_cluster;
>
> I don't think it makes sense to duplicate one value in two units.
>
> Fam
>
Eh, fair.
I just didn't want to duplicate the math everywhere. I can add a little
macro or an inline function instead.
--js