qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] usb: ohci avoid multiple eof timers


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH] usb: ohci avoid multiple eof timers
Date: Tue, 16 Feb 2016 15:17:24 +0100

On Di, 2016-02-16 at 15:34 +0530, P J P wrote:
> When transitioning an OHCI controller to the OHCI_USB_OPERATIONAL
> state, it creates an eof timer object in 'ohci_bus_start'.
> It does not check if one already exists. This results in memory
> leakage and null dereference issue. Add a check to avoid it.

Well, allocating and deallocating the timer all the time isn't a great
idea in the first place.  Can you try the attached patch instead?

thanks,
  Gerd

Attachment: 0001-ohci-timer-fix.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]