[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] net: check packet payload length
From: |
P J P |
Subject: |
[Qemu-devel] [PATCH] net: check packet payload length |
Date: |
Wed, 17 Feb 2016 17:38:24 +0530 |
From: Prasad J Pandit <address@hidden>
While computing IP checksum, 'net_checksum_calculate' reads
payload length from the packet. It could exceed the given 'data'
buffer size. Add a check to avoid it.
Reported-by: Liu Ling <address@hidden>
Signed-off-by: Prasad J Pandit <address@hidden>
---
net/checksum.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/checksum.c b/net/checksum.c
index 14c0855..e51698c 100644
--- a/net/checksum.c
+++ b/net/checksum.c
@@ -76,8 +76,9 @@ void net_checksum_calculate(uint8_t *data, int length)
return;
}
- if (plen < csum_offset+2)
- return;
+ if ((plen < csum_offset + 2) || (plen + hlen >= length)) {
+ return;
+ }
data[14+hlen+csum_offset] = 0;
data[14+hlen+csum_offset+1] = 0;
--
2.5.0
- [Qemu-devel] [PATCH] net: check packet payload length,
P J P <=
- Re: [Qemu-devel] [PATCH] net: check packet payload length, Markus Armbruster, 2016/02/17
- Re: [Qemu-devel] [PATCH] net: check packet payload length, P J P, 2016/02/17
- Re: [Qemu-devel] [PATCH] net: check packet payload length, P J P, 2016/02/18
- Re: [Qemu-devel] [PATCH] net: check packet payload length, Markus Armbruster, 2016/02/18
- Re: [Qemu-devel] [PATCH] net: check packet payload length, P J P, 2016/02/18
- Re: [Qemu-devel] [PATCH] net: check packet payload length, Jason Wang, 2016/02/23
- Re: [Qemu-devel] [PATCH] net: check packet payload length, P J P, 2016/02/23
- Re: [Qemu-devel] [PATCH] net: check packet payload length, Jason Wang, 2016/02/23
- Re: [Qemu-devel] [PATCH] net: check packet payload length, P J P, 2016/02/23