[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v0 4/8] spapr: Introduce CPU core device
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [RFC PATCH v0 4/8] spapr: Introduce CPU core device |
Date: |
Mon, 22 Feb 2016 07:44:40 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
Am 22.02.2016 um 06:01 schrieb Bharata B Rao:
> sPAPR CPU core device is a container of CPU thread devices. CPU hotplug is
> performed in the granularity of CPU core device by setting the "realized"
> property of this device to "true". When hotplugged, CPU core creates CPU
> thread devices.
>
> TODO: Right now allows for only homogeneous configurations as we depend
> on global smp_threads and machine->cpu_model.
>
> Signed-off-by: Bharata B Rao <address@hidden>
> ---
> hw/ppc/Makefile.objs | 1 +
> hw/ppc/spapr_cpu_package.c | 50
> ++++++++++++++++++++++++++++++++++++++
> include/hw/ppc/spapr_cpu_package.h | 26 ++++++++++++++++++++
> 3 files changed, 77 insertions(+)
> create mode 100644 hw/ppc/spapr_cpu_package.c
> create mode 100644 include/hw/ppc/spapr_cpu_package.h
>
> diff --git a/hw/ppc/Makefile.objs b/hw/ppc/Makefile.objs
> index c1ffc77..3000982 100644
> --- a/hw/ppc/Makefile.objs
> +++ b/hw/ppc/Makefile.objs
> @@ -4,6 +4,7 @@ obj-y += ppc.o ppc_booke.o
> obj-$(CONFIG_PSERIES) += spapr.o spapr_vio.o spapr_events.o
> obj-$(CONFIG_PSERIES) += spapr_hcall.o spapr_iommu.o spapr_rtas.o
> obj-$(CONFIG_PSERIES) += spapr_pci.o spapr_rtc.o spapr_drc.o spapr_rng.o
> +obj-$(CONFIG_PSERIES) += spapr_cpu_package.o
> ifeq ($(CONFIG_PCI)$(CONFIG_PSERIES)$(CONFIG_LINUX), yyy)
> obj-y += spapr_pci_vfio.o
> endif
> diff --git a/hw/ppc/spapr_cpu_package.c b/hw/ppc/spapr_cpu_package.c
> new file mode 100644
> index 0000000..3120a16
> --- /dev/null
> +++ b/hw/ppc/spapr_cpu_package.c
> @@ -0,0 +1,50 @@
> +/*
> + * sPAPR CPU package device, acts as container of CPU thread devices.
> + *
> + * Copyright (C) 2016 Bharata B Rao <address@hidden>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 or later.
> + * See the COPYING file in the top-level directory.
> + */
> +#include "hw/cpu/package.h"
> +#include "hw/ppc/spapr_cpu_package.h"
> +#include "hw/boards.h"
> +#include <sysemu/cpus.h>
> +#include "qemu/error-report.h"
> +
> +static void spapr_cpu_package_instance_init(Object *obj)
> +{
> + int i;
> + CPUState *cpu;
> + MachineState *machine = MACHINE(qdev_get_machine());
> + sPAPRCPUPackage *package = SPAPR_CPU_PACKAGE(obj);
> +
> + /* Create as many CPU threads as specified in the topology */
> + for (i = 0; i < smp_threads; i++) {
> + cpu = cpu_generic_init(machine->cpu_type, machine->cpu_model);
No, no, no. This is horribly violating QOM design.
Please compare the x86 RFC.
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
- [Qemu-devel] [RFC PATCH v0 0/8] cpu-package hotplug, Bharata B Rao, 2016/02/22
- [Qemu-devel] [RFC PATCH v0 1/8] cpu: Store CPU typename in MachineState, Bharata B Rao, 2016/02/22
- [Qemu-devel] [RFC PATCH v0 2/8] cpu: Don't realize CPU from cpu_generic_init(), Bharata B Rao, 2016/02/22
- [Qemu-devel] [RFC PATCH v0 3/8] cpu: CPU package abstract device, Bharata B Rao, 2016/02/22
- [Qemu-devel] [RFC PATCH v0 5/8] spapr: Convert boot CPUs into CPU core device initialization, Bharata B Rao, 2016/02/22
- [Qemu-devel] [RFC PATCH v0 4/8] spapr: Introduce CPU core device, Bharata B Rao, 2016/02/22
- Re: [Qemu-devel] [RFC PATCH v0 4/8] spapr: Introduce CPU core device,
Andreas Färber <=
- Re: [Qemu-devel] [RFC PATCH v0 4/8] spapr: Introduce CPU core device, Bharata B Rao, 2016/02/22
- Re: [Qemu-devel] [RFC PATCH v0 4/8] spapr: Introduce CPU core device, Andreas Färber, 2016/02/22
[Qemu-devel] [RFC PATCH v0 6/8] spapr: CPU hotplug support, Bharata B Rao, 2016/02/22
[Qemu-devel] [RFC PATCH v0 7/8] qmp: Implement query cpu-packages, Bharata B Rao, 2016/02/22
[Qemu-devel] [RFC PATCH v0 8/8] hmp: Implement 'info cpu-slots', Bharata B Rao, 2016/02/22