Re: [Qemu-devel] [PATCH 03/17] util: Shorten references into SocketAddress

[Daniel P. Berrange]

On Fri, Feb 19, 2016 at 05:19:33PM -0700, Eric Blake wrote:
> An upcoming patch will alter how simple unions, like SocketAddress,
> are laid out, which will impact all lines of the form 'addr->u.XXX'.
> To minimize the impact of that patch, use C99 initialization or a
> temporary variable to reduce the number of lines needing modification
> when an internal reference within SocketAddress changes layout.
> 
> Signed-off-by: Eric Blake <address@hidden>
> ---
>  block/nbd.c                    | 14 ++++++++------
>  qemu-char.c                    | 43 
> ++++++++++++++++++++++++------------------
>  qemu-nbd.c                     |  9 +++++----
>  tests/test-io-channel-socket.c | 26 ++++++++++++++++---------
>  ui/vnc.c                       | 39 +++++++++++++++++++-------------------
>  util/qemu-sockets.c            | 11 ++++++-----
>  6 files changed, 81 insertions(+), 61 deletions(-)

Reviewed-by: Daniel P. Berrange <address@hidden>

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|