[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] CONFIG_EPOLL vs CONFIG_EPOLL_CREATE1
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] CONFIG_EPOLL vs CONFIG_EPOLL_CREATE1 |
Date: |
Tue, 23 Feb 2016 09:15:03 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, 02/22 17:21, Matthew Fortune wrote:
> Hi,
>
> I've recently tried building qemu with a sysroot that has support
> for epoll_create but not epoll_create1.
>
> New code introduced in the following commit uses epoll_create1 but
> guards it using CONFIG_EPOLL rather than CONFIG_EPOLL_CREATE1.
>
> Is there any reason for this or can the guard be changed to
> use the latter config test?
Yes, this is an oversight and it should be CONFIG_EPOLL_CREATE1.
I'll send a patch to fix it.
Thanks.
Fam