[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/8] spice: init dcl before registering qxl interface
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 1/8] spice: init dcl before registering qxl interface |
Date: |
Tue, 23 Feb 2016 15:24:15 +0100 |
Without this spice might callback into qemu before ssd->dcl.con is
initialized, resulting in a segfault due to NULL pointer dereference.
Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
---
ui/spice-display.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/ui/spice-display.c b/ui/spice-display.c
index 8a5b325..cdbc78d 100644
--- a/ui/spice-display.c
+++ b/ui/spice-display.c
@@ -775,14 +775,14 @@ static void qemu_spice_display_init_one(QemuConsole *con)
qemu_spice_display_init_common(ssd);
+ ssd->dcl.ops = &display_listener_ops;
+ ssd->dcl.con = con;
+
ssd->qxl.base.sif = &dpy_interface.base;
qemu_spice_add_display_interface(&ssd->qxl, con);
assert(ssd->worker);
-
qemu_spice_create_host_memslot(ssd);
- ssd->dcl.ops = &display_listener_ops;
- ssd->dcl.con = con;
register_displaychangelistener(&ssd->dcl);
}
--
1.8.3.1
- [Qemu-devel] [PULL 0/8] spice: initial opengl/virgl support, postcopy migration fix., Gerd Hoffmann, 2016/02/23
- [Qemu-devel] [PULL 8/8] Postcopy+spice: Pass spice migration data earlier, Gerd Hoffmann, 2016/02/23
- [Qemu-devel] [PULL 6/8] spice/gl: add unblock timer, Gerd Hoffmann, 2016/02/23
- [Qemu-devel] [PULL 7/8] spice/gl: tweak debug messages., Gerd Hoffmann, 2016/02/23
- [Qemu-devel] [PULL 1/8] spice: init dcl before registering qxl interface,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 2/8] configure: add dma-buf support detection., Gerd Hoffmann, 2016/02/23
- [Qemu-devel] [PULL 4/8] spice: reset cursor on resize, Gerd Hoffmann, 2016/02/23
- [Qemu-devel] [PULL 5/8] spice: add opengl/virgl/dmabuf support, Gerd Hoffmann, 2016/02/23
- [Qemu-devel] [PULL 3/8] egl-helpers: add functions for render nodes and dma-buf passing, Gerd Hoffmann, 2016/02/23
- Re: [Qemu-devel] [PULL 0/8] spice: initial opengl/virgl support, postcopy migration fix., Peter Maydell, 2016/02/23