Re: [Qemu-devel] [PATCH v3 0/4] TriCore exception patches

[Richard Henderson]

On 02/19/2016 05:43 AM, Bastian Koppelmann wrote:
> v2 -> v3:
>      - raise_exception_sync_internal now directly modifies PC without
>        using the do_interrupt hook
>      - remove do_interrupt hook
>      - add fcd_pc to raise_exception_sync_internal to be used by
>        FCD traps
>      - add raise_exception_sync_helper wrapper to be used by
>        helper function that generate traps such that
>        raise_exception_sync_internal is only directly called for FCD traps
>      - add the generation of SOVF/OVF traps such that generate_trap()
>        is used to avoid a unused function compiler warning.
> 
> v1 -> v2:
>     - replace helper raise_exception_error by raise_exception_sync,
>       that takes care of saving the pre-interrupt state for synchronous
>       exceptions.
>     - rewrite of generate_trap() in translate.c. It directly
>       calls the raise_exception_sync helper instead of saving the
>       pre-interrupt state itself.    
>     - drop PATCH[2/5]: target-tricore: Save the pc before CSA operations for 
> exceptions
> 
> 
> Bastian Koppelmann (4):
>   target-tricore: Add trap handling & SOVF/OVF traps
>   target-tricore: add context managment trap generation
>   target-tricore: add illegal opcode trap generation
>   target-tricore: add opd trap generation
> 
>  target-tricore/cpu.h       |   1 +
>  target-tricore/helper.h    |   3 +
>  target-tricore/op_helper.c | 155 ++++++++++++++-
>  target-tricore/translate.c | 483 
> ++++++++++++++++++++++++++++++++++++++++++---
>  4 files changed, 610 insertions(+), 32 deletions(-)

Looks good.

Reviewed-by: Richard Henderson  <address@hidden>


r~