[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Postcopy: Fix sync count in info migrate
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH] Postcopy: Fix sync count in info migrate |
Date: |
Thu, 25 Feb 2016 10:59:37 +0000 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
* Hailiang Zhang (address@hidden) wrote:
> On 2016/2/25 18:03, Dr. David Alan Gilbert (git) wrote:
> >From: "Dr. David Alan Gilbert" <address@hidden>
> >
> >I'd missed the sync count off in the postcopy case.
> >
> >Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> >---
> > migration/migration.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/migration/migration.c b/migration/migration.c
> >index fc5e50b..34d3e5f 100644
> >--- a/migration/migration.c
> >+++ b/migration/migration.c
> >@@ -626,6 +626,7 @@ MigrationInfo *qmp_query_migrate(Error **errp)
> > info->ram->normal_bytes = norm_mig_bytes_transferred();
> > info->ram->dirty_pages_rate = s->dirty_pages_rate;
> > info->ram->mbps = s->mbps;
> >+ info->ram->dirty_sync_count = s->dirty_sync_count;
> >
> > if (blk_mig_active()) {
> > info->has_disk = true;
> >
>
> Reviewed-by: zhanghailiang <address@hidden>
Thanks,
> I noticed that, the stats of 'POSTCOPY_ACTIVE' is almost the copy of 'ACTIVE'
> case. Maybe we can simplify it.
Yes, I keep intending to add more stats to POSTCOPY_ACTIVE, but haven't
done so yet.
Dave
>
>
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK