[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/16] tcg mips64 and mips r6 improvements
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/16] tcg mips64 and mips r6 improvements |
Date: |
Mon, 29 Feb 2016 00:51:15 +0100 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On 2016-02-15 14:42, Richard Henderson wrote:
> Changes since v1:
> * Some bugs pointed out by Mark fixed.
> * Canonicalize the whole file on tcg_debug_assert.
> * Switch bswap code to subroutine earlier; the first patch is
> standalone for mips32, and there is no longer an intermediate
> patch with inline bswap for mips64.
> * Use NAL for pre-r6 mips64 loading of the slow path return address.
>
Thanks a lot for working on that, it's something I have on my TODO list
for months. I have finally found time to have a look and give a try over
the week-end (sorry about the delay).
It seems to work perfectly for 64-bit guests on mips64el but 32-bit
guests end-up quickly in a segmentation fault. It's easily reproducible
by starting qemu-system-i386 on a mips64el host, it crashes when
executing seabios.
More problematic it seems that the patch "Adjust qemu_ld/st for mips64"
causes a regression on at least a big-endian 32-bit host running
qemu-system-i386. It is reproducible by booting a Debian i386 wheezy
guest on such a system. Unfortunately the week-end was too short for
finding the issue, I'll continue looking in the next days.
I have a few comments on the individual patches, I'll send them asap.
Note that I don't have an R6 machine, so I haven't been able to test
that part.
Aurelien
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
address@hidden http://www.aurel32.net
- [Qemu-devel] [PATCH v2 08/16] tcg-mips: Adjust prologue for mips64, (continued)
- [Qemu-devel] [PATCH v2 08/16] tcg-mips: Adjust prologue for mips64, Richard Henderson, 2016/02/14
- [Qemu-devel] [PATCH v2 09/16] tcg-mips: Add tcg unwind info, Richard Henderson, 2016/02/14
- [Qemu-devel] [PATCH v2 10/16] tcg-mips: Adjust qemu_ld/st for mips64, Richard Henderson, 2016/02/14
- [Qemu-devel] [PATCH v2 11/16] tcg-mips: Adjust calling conventions for mips64, Richard Henderson, 2016/02/14
- [Qemu-devel] [PATCH v2 12/16] tcg-mips: Improve tcg_out_movi for mips64, Richard Henderson, 2016/02/14
- [Qemu-devel] [PATCH v2 13/16] tcg-mips: Use mips64r6 instructions in tcg_out_ldst, Richard Henderson, 2016/02/14
- [Qemu-devel] [PATCH v2 14/16] tcg-mips: Use mips64r6 instructions in constant addition, Richard Henderson, 2016/02/14
- [Qemu-devel] [PATCH v2 16/16] tcg-mips: Use mipsr6 instructions in calls, Richard Henderson, 2016/02/14
- [Qemu-devel] [PATCH v2 15/16] tcg-mips: Use mipsr6 instructions in branches, Richard Henderson, 2016/02/14
- Re: [Qemu-devel] [PATCH v2 00/16] tcg mips64 and mips r6 improvements, Richard Henderson, 2016/02/14
- Re: [Qemu-devel] [PATCH v2 00/16] tcg mips64 and mips r6 improvements,
Aurelien Jarno <=