qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 5/9] i.MX: Add i.MX6 CCM and ANALOG device.


From: Jean-Christophe DUBOIS
Subject: Re: [Qemu-devel] [PATCH v2 5/9] i.MX: Add i.MX6 CCM and ANALOG device.
Date: Mon, 29 Feb 2016 21:15:19 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1

Le 29/02/2016 18:33, Peter Maydell a écrit :
On 8 February 2016 at 22:08, Jean-Christophe Dubois <address@hidden> wrote:
Signed-off-by: Jean-Christophe Dubois <address@hidden>
---
+static uint64_t imx6_ccm_read(void *opaque, hwaddr offset, unsigned size)
+{
+    uint32 value = 0;
This should be 'uint32_t', not 'uint32'.

(You'll find this doesn't compile on current master if you rebase it;
uint32 was a type intended only for use with the softfloat code, and
we've just eliminated it.)

Similar issues in imx6_src_read() and imx_spi_read().

You also need to make sure all your new .c files have #include "qemu/osdep.h"
as the first include they do, or they won't build on current master.

OK, I'll do.


thanks
-- PMM





reply via email to

[Prev in Thread] Current Thread [Next in Thread]