Re: [Qemu-devel] [PATCH 1/1] log: fix hanged connect from virt-manager to libvirt

[Denis V. Lunev]

On 03/03/2016 04:49 PM, Paolo Bonzini wrote:
> On 03/03/2016 14:48, Denis V. Lunev wrote:
> > libvirt in this case spawns
> >    /usr/bin/qemu-system-x86_64 -S -no-user-config -nodefaults -nographic
> >      -M none
> >      -qmp unix:/var/lib/libvirt/qemu/capabilities.monitor.sock,server,nowait
> >      -pidfile /var/lib/libvirt/qemu/capabilities.pidfile -daemonize
> > and with CONFIG_TRACE_LOG this process hangs as stderr becomes redirected
> > to terminal (qemu_logfile == stderr). We do not have redirection to
> > /dev/null in this case which is necessary.
> >
> > Broken by:
> >      commit 96c33a4523ee1abe382ce4ff3e82b90ba78aa186
> >      Author: Dimitris Aragiorgis <address@hidden>
> >      Date:   Thu Feb 18 13:38:38 2016 +0200
> >
> >      log: Redirect stderr to logfile if deamonized
> >
> > We should also take into account log filename change in runtime through
> > QMP/HMP, when the log could be even closed. In this case stderr should
> > be tweaked accordingly.
> >
> > Signed-off-by: Denis V. Lunev <address@hidden>
> > CC: Dimitris Aragiorgis <address@hidden>
> > CC: Paolo Bonzini <address@hidden>
> > CC: Vladimir Sementsov-Ogievskiy <address@hidden>
> A patch has been posted already, and I'll send a pull request tomorrow.
>
> Paolo
I have not seen it. Can you post a link?

By the way, there are other cases fixed here, thus may be some
follow up is necessary that is why I am asking.

Den