[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 09/10] chardev: Drop useless ChardevDummy typ
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 09/10] chardev: Drop useless ChardevDummy type |
Date: |
Fri, 4 Mar 2016 08:25:21 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 03/04/2016 07:40 AM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
>
>> Commit d0d7708b made ChardevDummy be an empty wrapper type around
>> ChardevCommon. But there is no technical reason for this indirection,
>> so simplify the code by directly using the base type.
>>
>> Also change the fallback assignment to assign u.null rather than
>> u.data, since a future patch will remove the data member of the C
>> struct generated for QAPI unions.
>>
>> Signed-off-by: Eric Blake <address@hidden>
>> Reviewed-by: Daniel P. Berrange <address@hidden>
>
> Doesn't compile with MinGW:
>
> qemu/qemu-char.c: In function 'qemu_chr_open_win_con':
> qemu/qemu-char.c:2186:29: warning: implicit declaration of function
> 'qapi_ChardevDummy_base' [-Wimplicit-function-declaration]
> ChardevCommon *common = qapi_ChardevDummy_base(backend->u.console);
> ^
The curse of not compiling all the backends, and failing to grep for
ChardevDummy. Replacement patch coming up soon.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 00/10] easier unboxed visits/qapi implicit types, Eric Blake, 2016/03/03
- [Qemu-devel] [PATCH v3 01/10] qapi: Rename 'fields' to 'members' in generator, Eric Blake, 2016/03/03
- [Qemu-devel] [PATCH v3 04/10] qapi: Update docs to match recent generator changes, Eric Blake, 2016/03/03
- [Qemu-devel] [PATCH v3 03/10] qapi-visit: Expose visit_type_FOO_members(), Eric Blake, 2016/03/03
- [Qemu-devel] [PATCH v3 09/10] chardev: Drop useless ChardevDummy type, Eric Blake, 2016/03/03
- [Qemu-devel] [PATCH v3 02/10] qapi: Rename 'fields' to 'members' in generated C code, Eric Blake, 2016/03/03
- [Qemu-devel] [PATCH v3 05/10] chardev: Shorten references into ChardevBackend, Eric Blake, 2016/03/03
- [Qemu-devel] [PATCH v3 08/10] qapi: Avoid use of 'data' member of QAPI unions, Eric Blake, 2016/03/03
- [Qemu-devel] [PATCH v3 10/10] qapi: Drop useless 'data' member of unions, Eric Blake, 2016/03/03
- [Qemu-devel] [PATCH v3 06/10] util: Shorten references into SocketAddress, Eric Blake, 2016/03/03
- [Qemu-devel] [PATCH v3 07/10] ui: Shorten references into InputEvent, Eric Blake, 2016/03/03
- Re: [Qemu-devel] [PATCH v3 00/10] easier unboxed visits/qapi implicit types, Markus Armbruster, 2016/03/04