qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v2][Outreachy Round 12]


From: Sarah Khan
Subject: [Qemu-devel] [PATCH v2][Outreachy Round 12]
Date: Fri, 4 Mar 2016 22:39:30 +0530

Replaced g_malloc() with g_new() as it would detect multiplication overflow if 
nb_fields ever oversize.

There is no corresponding free(). thunk_register_struct() is called
only at startup from the linux-user code in order to populate the
struct_entries array; this data structure then remains live for
the entire lifetime of the program and is automatically freed when
QEMU exits.

This replacement was suggested as part of the bite-sized tasks.

Signed-off-by: Sarah Khan <address@hidden>
---
Changes in v2 :Make commit message clearer
               Replace g_malloc() with g_new()  
---
 thunk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/thunk.c b/thunk.c
index bddabae..6237702 100644
--- a/thunk.c
+++ b/thunk.c
@@ -88,7 +88,7 @@ void thunk_register_struct(int id, const char *name, const 
argtype *types)
     for(i = 0;i < 2; i++) {
         offset = 0;
         max_align = 1;
-        se->field_offsets[i] = g_malloc(nb_fields * sizeof(int));
+        se->field_offsets[i] = g_new(int,nb_fields);
         type_ptr = se->field_types;
         for(j = 0;j < nb_fields; j++) {
             size = thunk_type_size(type_ptr, i);
-- 
1.9.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]