Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

[Changlong Xie]

On 03/11/2016 08:21 PM, Alberto Garcia wrote:
> On Thu 10 Mar 2016 03:49:40 AM CET, Changlong Xie wrote:
> > @@ -81,6 +82,8 @@ typedef struct BDRVQuorumState {
> >       bool rewrite_corrupted;/* true if the driver must rewrite-on-read 
> > corrupted
> >                               * block if Quorum is reached.
> >                               */
> > +    unsigned long *index_bitmap;
> > +    int bsize;
>    [...]
> > +static int get_new_child_index(BDRVQuorumState *s)
>    [...]
> > +static void remove_child_index(BDRVQuorumState *s, int index)
>    [...]
>
> Sorry if I missed a previous discussion, but why is this necessary?

Hi Betro

Currently we implement this for COLO, we need the capability to hotplug 
NBD child in COLO mode.

More detail please reference 
http://wiki.qemu.org/Features/BlockReplication.

Thanks
        -Xie

> Berto
>
>
> .