Re: [Qemu-devel] [PATCH v2] Sort the fw_cfg file list

[Michael S. Tsirkin]

On Tue, Mar 15, 2016 at 08:04:48AM +0100, Gerd Hoffmann wrote:
>   Hi,
> 
> > > Don't add a new machine type in this version, just use the 2.6 one.
> > 
> > Unfortunately this patch won't help any, as your next patch reorders fw
> > cfg files which will affect the old machine types.
> 
> We can make that depend on dont_sort_fw_cfgs too, to keep things as-is
> on old machine types.

Yes, except the name is a bit off then. It's more "legacy_fw_cfg_order"
than "dont_sort_fw_cfgs".

> Which probably implies only new machine types
> will see the new smbios entries.
> 
> cheers,
>   Gerd

Not really I think.
If there's a new device triggering a new smbios entry, we don't care how
it's sorted since by then there's no question of cross-version migration
with old QEMU.

-- 
MST