[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/acpi: fix GSI links UID
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] hw/acpi: fix GSI links UID |
|
Date: |
Tue, 15 Mar 2016 18:27:56 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 13/03/2016 12:40, Marcel Apfelbaum wrote:
> According to the ACPI spec, each UID must be unique.
> Use the irq number as UID for GSI links.
>
> Suggested-by: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Marcel Apfelbaum <address@hidden>
This causes a warning from acpi-test. The diff is
2720c2720
< Name (_UID, Zero) // _UID: Unique ID
---
> Name (_UID, 0x10) // _UID: Unique ID
2747c2747
< Name (_UID, Zero) // _UID: Unique ID
---
> Name (_UID, 0x11) // _UID: Unique ID
2774c2774
< Name (_UID, Zero) // _UID: Unique ID
---
> Name (_UID, 0x12) // _UID: Unique ID
2801c2801
< Name (_UID, Zero) // _UID: Unique ID
---
> Name (_UID, 0x13) // _UID: Unique ID
2828c2828
< Name (_UID, Zero) // _UID: Unique ID
---
> Name (_UID, 0x14) // _UID: Unique ID
2855c2855
< Name (_UID, Zero) // _UID: Unique ID
---
> Name (_UID, 0x15) // _UID: Unique ID
2882c2882
< Name (_UID, Zero) // _UID: Unique ID
---
> Name (_UID, 0x16) // _UID: Unique ID
2909c2909
< Name (_UID, Zero) // _UID: Unique ID
---
> Name (_UID, 0x17) // _UID: Unique ID
I think you should have updated tests/acpi-test-data.
Paolo