[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/15] Don't include qemu-common.h in headers
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 14/15] Don't include qemu-common.h in headers |
Date: |
Tue, 15 Mar 2016 17:53:56 +0000 |
On 15 March 2016 at 17:44, Paolo Bonzini <address@hidden> wrote:
> Well, osdep.h is the new qemu-common.h. At least it doesn't include
> other^Wtoo many other QEMU header files, but it does have a lot of
> prototypes that are even more out of place than fprintf_function.
Yes, those should be moved to somewhere else, they're in the
wrong place (as noted in the comment at the top of osdep.h).
The comment at the top of osdep.h describes the plan:
* In an ideal world this header would contain only:
* (1) things which everybody needs
* (2) things without which code would work on most platforms but
* fail to compile or misbehave on a minority of host OSes
and I think we should be aiming to move towards the ideal world
rather than away from it.
thanks
-- PMM
- [Qemu-devel] [PATCH 12/15] isa: Move DMA_transfer_handler from qemu-common.h to hw/isa/isa.h, (continued)
[Qemu-devel] [PATCH 15/15] Drop superfluous qemu-common.h inclusions, Markus Armbruster, 2016/03/15
[Qemu-devel] [PATCH 01/15] include/qemu/osdep.h: Don't include qapi/error.h, Markus Armbruster, 2016/03/15
Re: [Qemu-devel] [PATCH 00/15] Clean up around osdep.h and qemu-common.h, Paolo Bonzini, 2016/03/15