[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without o
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/ |
Date: |
Thu, 17 Mar 2016 10:40:24 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 17/03/2016 09:49, Laszlo Ersek wrote:
> On 03/16/16 21:31, Michael S. Tsirkin wrote:
>> On Wed, Mar 16, 2016 at 07:35:09PM +0100, Laszlo Ersek wrote:
>>> OVMF uses this feature for a few flags. They are all called
>>> "opt/ovmf/...". I followed the advice in "docs/specs/fw_cfg.txt" (which
>>> shouldn't be surprising since I seem to have reviewed every patch for
>>> that file):
>>
>> Wait a second. You are saying upsteam OVMF puts files there.
>
> Sorry, I wasn't clear enough. OVMF consumes files that are put there by
> the user.
I think what Michael is saying is that OVMF now has to worry about users
calling their own files "opt/ovmf/foo" and causing a conflict.
I actually agree with his worry, but probably not with how to resolve
it. For me, the way to resolve it would be:
1) files should actually be named etc/ovmf/foo. OVMF could optionally
accept both the old and the new names for a while, you would decide
whether this is useful.
2) in turn, because of (1) even the warning on opt/ should be removed.
Paolo
- Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/, (continued)
- Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/, Markus Armbruster, 2016/03/16
- Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/, Michael S. Tsirkin, 2016/03/16
- Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/, Gabriel L. Somlo, 2016/03/16
- Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/, Laszlo Ersek, 2016/03/16
- Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/, Michael S. Tsirkin, 2016/03/16
- Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/, Laszlo Ersek, 2016/03/16
- Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/, Michael S. Tsirkin, 2016/03/16
- Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/, Michael S. Tsirkin, 2016/03/16
- Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/, Michael S. Tsirkin, 2016/03/16
- Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/, Laszlo Ersek, 2016/03/17
- Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/, Michael S. Tsirkin, 2016/03/17
- Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/, Paolo Bonzini, 2016/03/17
- Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/, Michael S. Tsirkin, 2016/03/17
- Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/, Gerd Hoffmann, 2016/03/17
- Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/, Laszlo Ersek, 2016/03/17
- Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/, Gerd Hoffmann, 2016/03/17
- Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/, Laszlo Ersek, 2016/03/17
- Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/, Michael S. Tsirkin, 2016/03/17
- Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/, Paolo Bonzini, 2016/03/17
- Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/, Gerd Hoffmann, 2016/03/17