Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/

[Michael S. Tsirkin]

On Thu, Mar 17, 2016 at 08:35:25PM +0100, Paolo Bonzini wrote:
> 
> 
> On 17/03/2016 18:17, Gerd Hoffmann wrote:
> >   Hi,
> > 
> >> Alternative: fail on:
> >>
> >> - a blacklist of etc/* files including etc/system-states,
> >> etc/smbios/smbios-tables, etc/smbios/smbios-anchor,
> >> etc/reserved-memory-end, etc/pvpanic-port, etc/e820, and possibly
> >> etc/boot-menu-wait
> > 
> > I think that fails already because qemu throws an error on duplicate
> > firmware entries.
> 
> The problem is that some files are only added conditionally (e.g.
> etc/boot-menu-wait).

Another problem is that future firmware can run on an older QEMU.
Any blacklist-only strategy fails because of that, we need
a schema.

> > Do we really want shuffle around stuff like this?  It means we have to
> > support both paths in both firmware and qemu for a quite a while for
> > compatibility reasons.
> > 
> > Also note that most stuff in etc/ is used by all firmwares, so moving
> > this to org.seabios looks pointless to me, especially as things might
> > change over time (i.e. ovmf starting to use cfg options it used to
> > ignore first, which is the case for etc/boot-menu-wait IIRC, so it
> > started as seabios only but isn't any more).
> 
> Stuff that is used by all firmwares could move to org.coreboot/ or
> org.qemu/, but keeping etc/ as a special case is certainly fine by me.
> 
> Paolo