[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 16/16] qapi: Consolidate object visitors
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v6 16/16] qapi: Consolidate object visitors |
Date: |
Fri, 18 Mar 2016 08:47:09 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Eric Blake <address@hidden> writes:
> Rather than having two separate visitor callbacks with items
> already broken out, pass the actual QAPISchemaObjectType object
> to the visitor. This lets the visitor access things like
> type.is_implicit() without needing another parameter, resolving
> a TODO from previous patches.
>
> For convenience and consistency, the 'name' and 'info' parameters
> are still provided, even though they are now redundant with
> 'typ.name' and 'typ.info'.
>
> Signed-off-by: Eric Blake <address@hidden>
$ for i in `git-ls-files tests/qapi-schema/\*.out`; do diff -q $i
bld-x86/${i%.out}.test.out; done
Files tests/qapi-schema/comments.out and
bld-x86/tests/qapi-schema/comments.test.out differ
Files tests/qapi-schema/empty.out and bld-x86/tests/qapi-schema/empty.test.out
differ
Files tests/qapi-schema/event-case.out and
bld-x86/tests/qapi-schema/event-case.test.out differ
Files tests/qapi-schema/ident-with-escape.out and
bld-x86/tests/qapi-schema/ident-with-escape.test.out differ
Files tests/qapi-schema/include-relpath.out and
bld-x86/tests/qapi-schema/include-relpath.test.out differ
Files tests/qapi-schema/include-repetition.out and
bld-x86/tests/qapi-schema/include-repetition.test.out differ
Files tests/qapi-schema/include-simple.out and
bld-x86/tests/qapi-schema/include-simple.test.out differ
Files tests/qapi-schema/indented-expr.out and
bld-x86/tests/qapi-schema/indented-expr.test.out differ
Files tests/qapi-schema/qapi-schema-test.out and
bld-x86/tests/qapi-schema/qapi-schema-test.test.out differ
> ---
> v6: new patch
Let's punt this one to a later iteration.
- [Qemu-devel] [PATCH v6 00/16] easier unboxed visits/qapi implicit types, Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 01/16] qapi: Assert in places where variants are not handled, Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 06/16] qapi-event: Drop qmp_output_get_qobject() null check, Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 02/16] qapi: Fix command with named empty argument type, Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 07/16] qapi-event: Utilize implicit struct visits, Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 09/16] qapi-commands: Inline single-use helpers of gen_marshal(), Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 13/16] qapi: Make BlockdevOptions doc example closer to reality, Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 16/16] qapi: Consolidate object visitors, Eric Blake, 2016/03/17
- Re: [Qemu-devel] [PATCH v6 16/16] qapi: Consolidate object visitors,
Markus Armbruster <=
- [Qemu-devel] [PATCH v6 11/16] qapi: Drop unused c_null(), Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 04/16] qapi: Adjust names of implicit types, Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 03/16] qapi: Make c_type() more OO-like, Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 10/16] qapi: Inline gen_visit_members() into lone caller, Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 05/16] qapi: Emit implicit structs in generated C, Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 08/16] qapi-commands: Utilize implicit struct visits, Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 14/16] qapi: Allow anonymous base for flat union, Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 15/16] qapi: Use anonymous bases in QMP flat unions, Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 12/16] qapi: Don't special-case simple union wrappers, Eric Blake, 2016/03/17
- Re: [Qemu-devel] [PATCH v6 00/16] easier unboxed visits/qapi implicit types, Markus Armbruster, 2016/03/18