[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 04/15] register: Add support for decoding inf
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v5 04/15] register: Add support for decoding information |
Date: |
Tue, 22 Mar 2016 17:42:56 +0000 |
User-agent: |
mu4e 0.9.17; emacs 25.0.92.7 |
Alistair Francis <address@hidden> writes:
> Allow defining of optional address decoding information in register
> definitions. This is useful for clients that want to associate
> registers with specific addresses.
>
> Signed-off-by: Peter Crosthwaite <address@hidden>
> Signed-off-by: Alistair Francis <address@hidden>
> ---
> V3:
> - Remove unused flags option
>
> include/hw/register.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/hw/register.h b/include/hw/register.h
> index 726a914..bc2c96a 100644
> --- a/include/hw/register.h
> +++ b/include/hw/register.h
> @@ -39,6 +39,11 @@ typedef struct RegisterInfoArray RegisterInfoArray;
> * allowing this function to modify the value before return to the client.
> */
>
> +#define REG_DECODE_READ (1 << 0)
> +#define REG_DECODE_WRITE (1 << 1)
> +#define REG_DECODE_EXECUTE (1 << 2)
> +#define REG_DECODE_RW (REG_DECODE_READ | REG_DECODE_WRITE)
> +
> struct RegisterAccessInfo {
> const char *name;
> uint64_t ro;
Without any other context I'm unsure of how these defines are going to
be used. Are these just bits at the bottom of an address?
Nothing in this patch series uses them so I suggest you drop this patch
for now.
--
Alex Bennée
- [Qemu-devel] [PATCH v5 00/15] data-driven device registers, Alistair Francis, 2016/03/08
- [Qemu-devel] [PATCH v5 01/15] bitops: Add MAKE_64BIT_MASK macro, Alistair Francis, 2016/03/08
- [Qemu-devel] [PATCH v5 02/15] register: Add Register API, Alistair Francis, 2016/03/08
- [Qemu-devel] [PATCH v5 03/15] register: Add Memory API glue, Alistair Francis, 2016/03/08
- [Qemu-devel] [PATCH v5 04/15] register: Add support for decoding information, Alistair Francis, 2016/03/08
- Re: [Qemu-devel] [PATCH v5 04/15] register: Add support for decoding information,
Alex Bennée <=
- [Qemu-devel] [PATCH v5 05/15] register: Define REG and FIELD macros, Alistair Francis, 2016/03/08
- [Qemu-devel] [PATCH v5 06/15] register: QOMify, Alistair Francis, 2016/03/08
- [Qemu-devel] [PATCH v5 07/15] register: Add block initialise helper, Alistair Francis, 2016/03/08
- [Qemu-devel] [PATCH v5 08/15] dma: Add Xilinx Zynq devcfg device model, Alistair Francis, 2016/03/08
- [Qemu-devel] [PATCH v5 09/15] xilinx_zynq: Connect devcfg to the Zynq machine model, Alistair Francis, 2016/03/08
- [Qemu-devel] [PATCH v5 10/15] qdev: Define qdev_get_gpio_out, Alistair Francis, 2016/03/08
- [Qemu-devel] [PATCH v5 14/15] misc: Introduce ZynqMP IOU SLCR, Alistair Francis, 2016/03/08