Re: [Qemu-devel] [PULL 00/21] target-mips queue for 2.6

[Peter Maydell]

On 29 March 2016 at 10:56, Leon Alrae <address@hidden> wrote:
> Hi,
>
> Here's MIPS pull request which adds initial implementation of MIPS Coherent
> Processing System including Cluster Power Controller and Global Config
> Registers allowing the guest to control the start of other Virtual
> Processors after reset. Also, this pullreq adds Inter-Thread Communication
> Unit and MAAR.
>
> Thanks,
> Leon
>
> Cc: Peter Maydell <address@hidden>
> Cc: Aurelien Jarno <address@hidden>
>
> The following changes since commit b68a80139e37e806f004237e55311ebc42151434:
>
>   Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20160324' into 
> staging (2016-03-24 16:24:02 +0000)
>
> are available in the git repository at:
>
>   git://github.com/lalrae/qemu.git tags/mips-20160329
>
> for you to fetch changes up to e9f517b73dab520de05b871359d2beedf8b04e53:
>
>   target-mips: add MAAR, MAARI register (2016-03-28 19:27:09 +0100)
>
> ----------------------------------------------------------------
> MIPS patches 2016-03-29
>
> Changes:
> * add initial MIPS CPS support
> * implement ITU block
> * implement MAAR

Hi. I'm afraid this doesn't compile:
/home/petmay01/linaro/qemu-for-merges/hw/misc/mips_cmgcr.c: In
function ‘mips_gcr_init’:
/home/petmay01/linaro/qemu-for-merges/hw/misc/mips_cmgcr.c:107:31:
error: ‘error_abort’ undeclared (first use in this function)
                              &error_abort);
                               ^
/home/petmay01/linaro/qemu-for-merges/hw/misc/mips_cmgcr.c:107:31:
note: each undeclared identifier is reported only once for each
function it appears in
  CC    mips64-softmmu/hw/misc/mips_itu.o
make[1]: *** [hw/misc/mips_cmgcr.o] Error 1
make[1]: *** Waiting for unfinished jobs....
  CC    mips64el-softmmu/hw/misc/mips_cmgcr.o
/home/petmay01/linaro/qemu-for-merges/hw/misc/mips_cpc.c: In function
‘mips_cpc_realize’:
/home/petmay01/linaro/qemu-for-merges/hw/misc/mips_cpc.c:119:9: error:
implicit declaration of function ‘error_setg’
[-Werror=implicit-function-declaration]
         error_setg(errp,
         ^
/home/petmay01/linaro/qemu-for-merges/hw/misc/mips_cpc.c:119:9: error:
nested extern declaration of ‘error_setg’ [-Werror=nested-externs]
cc1: all warnings being treated as errors

(and similar other errors).

I think you've unfortunately collided with a patch in Paolo's
recent pull request which changes how we handle qapi/error.h
(it's no longer pulled in by osdep.h by default); see commit
da34e65cb.

thanks
-- PMM