[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 2/5] net: Allocating Large sized arrays to heap
From: |
Jason Wang |
Subject: |
[Qemu-devel] [PULL 2/5] net: Allocating Large sized arrays to heap |
Date: |
Wed, 6 Apr 2016 10:37:57 +0800 |
From: Pooja Dhannawat <address@hidden>
nc_sendv_compat has a huge stack usage of 69680 bytes approx.
Moving large arrays to heap to reduce stack usage.
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Pooja Dhannawat <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
---
net/net.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/net/net.c b/net/net.c
index 0bc42a1..f8b1e00 100644
--- a/net/net.c
+++ b/net/net.c
@@ -683,23 +683,28 @@ ssize_t qemu_send_packet_raw(NetClientState *nc, const
uint8_t *buf, int size)
static ssize_t nc_sendv_compat(NetClientState *nc, const struct iovec *iov,
int iovcnt, unsigned flags)
{
- uint8_t buf[NET_BUFSIZE];
+ uint8_t *buf = NULL;
uint8_t *buffer;
size_t offset;
+ ssize_t ret;
if (iovcnt == 1) {
buffer = iov[0].iov_base;
offset = iov[0].iov_len;
} else {
+ buf = g_new(uint8_t, NET_BUFSIZE);
buffer = buf;
- offset = iov_to_buf(iov, iovcnt, 0, buf, sizeof(buf));
+ offset = iov_to_buf(iov, iovcnt, 0, buf, NET_BUFSIZE);
}
if (flags & QEMU_NET_PACKET_FLAG_RAW && nc->info->receive_raw) {
- return nc->info->receive_raw(nc, buffer, offset);
+ ret = nc->info->receive_raw(nc, buffer, offset);
} else {
- return nc->info->receive(nc, buffer, offset);
+ ret = nc->info->receive(nc, buffer, offset);
}
+
+ g_free(buf);
+ return ret;
}
ssize_t qemu_deliver_packet_iov(NetClientState *sender,
--
2.5.0
- [Qemu-devel] [PULL 0/5] Net patches, Jason Wang, 2016/04/05
- [Qemu-devel] [PULL 1/5] util: Improved qemu_hexmap() to include an ascii dump of the buffer, Jason Wang, 2016/04/05
- [Qemu-devel] [PULL 2/5] net: Allocating Large sized arrays to heap,
Jason Wang <=
- [Qemu-devel] [PULL 3/5] net: fix OptsVisitor memory leak, Jason Wang, 2016/04/05
- [Qemu-devel] [PULL 4/5] rtl8139: using CP_TX_OWN for ownership transferring during tx, Jason Wang, 2016/04/05
- [Qemu-devel] [PULL 5/5] filter-buffer: fix segfault when starting qemu with status=off property, Jason Wang, 2016/04/05
- Re: [Qemu-devel] [PULL 0/5] Net patches, Peter Maydell, 2016/04/07