qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 1/2] net: stellaris_enet: check packet length agains


From: P J P
Subject: [Qemu-devel] [PATCH 1/2] net: stellaris_enet: check packet length against receive buffer
Date: Thu, 7 Apr 2016 15:55:31 +0530

From: Prasad J Pandit <address@hidden>

When receiving packets over Stellaris ethernet controller, it
uses receive buffer of size 2048 bytes. In case the controller
accepts large(MTU) packets, it could lead to memory corruption.
Add check to avoid it.

Reported by: Oleksandr Bazhaniuk <address@hidden>

Signed-off-by: Prasad J Pandit <address@hidden>
---
 hw/net/stellaris_enet.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/net/stellaris_enet.c b/hw/net/stellaris_enet.c
index 21a4773..47b869a 100644
--- a/hw/net/stellaris_enet.c
+++ b/hw/net/stellaris_enet.c
@@ -237,6 +237,9 @@ static ssize_t stellaris_enet_receive(NetClientState *nc, 
const uint8_t *buf, si
         n -= 31;
     s->np++;
 
+    if (size >= sizeof(s->rx[n].data) - 6) {
+        return -1;
+    }
     s->rx[n].len = size + 6;
     p = s->rx[n].data;
     *(p++) = (size + 6);
-- 
2.5.5




reply via email to

[Prev in Thread] Current Thread [Next in Thread]