[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tb: consistently use uint32_t for tb->flags
|
From: |
Emilio G. Cota |
|
Subject: |
Re: [Qemu-devel] [PATCH] tb: consistently use uint32_t for tb->flags |
|
Date: |
Thu, 7 Apr 2016 13:23:00 -0400 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Apr 07, 2016 at 13:19:22 -0400, Emilio G. Cota wrote:
> We are inconsistent with the type of tb->flags: usage varies loosely
> between int and uint64_t. Settle to uint32_t everywhere, which is
> superior to both: at least one target (aarch64) uses the most significant
> bit in the u32, and uint64_t is wasteful.
>
> Compile-tested for all targets.
>
> Suggested-by: Laurent Desnogues <address@hidden>
> Suggested-by: Richard Henderson <address@hidden>
> Signed-off-by: Emilio G. Cota <address@hidden>
Context:
https://lists.gnu.org/archive/html/qemu-devel/2016-04/msg01110.html
Thanks,
Emilio