[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 48/48] iotests: Test qemu-img convert -S 0 behavi
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PULL 48/48] iotests: Test qemu-img convert -S 0 behavior |
Date: |
Fri, 8 Apr 2016 09:18:48 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, 04/07 16:40, Paolo Bonzini wrote:
>
>
> On 29/03/2016 17:08, Kevin Wolf wrote:
> > From: Max Reitz <address@hidden>
> >
> > Passing -S 0 to qemu-img convert should result in all source data being
> > copied to the output, even if that source data is known to be 0. The
> > output image should therefore have exactly the same size on disk as an
> > image which we explicitly filled with data.
> >
> > Signed-off-by: Max Reitz <address@hidden>
> > Reviewed-by: Fam Zheng <address@hidden>
> > Signed-off-by: Kevin Wolf <address@hidden>
>
> This fails with XFS and raw format, which preallocates an extra cluster
> at the end of the file created with qemu-io (so that the on-disk size is
> 2056 512-byte blocks).
Maybe squash in http://patchwork.ozlabs.org/patch/603047/ ?
Fam